Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing types to component properties #222

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Add missing types to component properties #222

merged 1 commit into from
Nov 25, 2024

Conversation

damsfx
Copy link
Contributor

@damsfx damsfx commented Nov 25, 2024

No description provided.

@mjauvin mjauvin self-assigned this Nov 25, 2024
@mjauvin mjauvin requested a review from LukeTowers November 25, 2024 15:27
@mjauvin
Copy link
Member

mjauvin commented Nov 25, 2024

@damsfx Other pages use the full path to the UI docs like below:

[Winter CMS icon collection](/docs/v1.2/ui/style/icon), maybe we should do the same here.

LukeTowers
LukeTowers approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@LukeTowers LukeTowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer the relative path here, especially now that we have multiple versions of the docs

@LukeTowers LukeTowers merged commit 4e2fb9a into wintercms:develop Nov 25, 2024
1 check passed
@damsfx damsfx deleted the damsfx-add-missing-component-properties-types branch December 19, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukeTowers LukeTowers LukeTowers approved these changes

Assignees

@mjauvin mjauvin

Labels
Status: Review Needed Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@damsfx @mjauvin @LukeTowers